one-span-sign npm module

Hi Tewen, Exciting to see your code share! I've tried your module and briefly walked through the source codes, it's really well-built! Despite of my poor Node.Js skills, I can still find it very clean and well-structured with good programming practices that I should learn from. Here's few feedback after initial experience that I'd like to share with you: #1. I found out that sandbox url is binded to "sandbox.e-signlive.com" (US1 sandbox environment), as most of the users may have sandbox account with "sandbox.esignlive.com"(US2 sandbox environment), it probably be better to let users enter the api_url themselves, because besides these two sandbox urls, OneSpan Sign also has many other instances for both sandbox and production where you can find in this documentation: https://docs.esignlive.com/content/c_integrator_s_guide/rest_api/rest_api.htm?Highlight=api%20url#The_API_URLs #2. I found out that currently, all fields on documents are located by "Position Extraction" feature, which is a match with the name of PDF Form Field to the name of the model object Field. If this could be mentioned on Readme file and potentially can be extended to other extraction methods, it would be so great! #3. Just a little suggestion from my own point of view. Before extending more functions, it's better to decide whether the models will be align with the JSON object or you want your own encapsulation. If you go with your own model design, it could take more code to make converters like splitApprovals() and few other functions in package.js does. I've updated the whole JSON Property table of a package where you can find at the bottom of our quick-start REST guide: https://developer.esignlive.com/guides/quick-start/creating-and-sending-a-package-rest/ Which probably will give you some hint about the total scopes of your module Really appreciate your contribution! This is really my very first impression, I will leave more replies in this thread and we can talk more on this! Thanks, Duo

Duo - Thanks for the thorough look. Really appreciate it. For #1 & #3, I just created Github issues: https://github.com/tewen/one-span-sign/issues/17 & https://github.com/tewen/one-span-sign/issues/16 respectively. Feel free to add any issues or comments there now and in the future as well. It's an open source project, and that naturally includes you and anyone else on the One Span team. Also always happy for you to make a pull request, even if you claim you have poor Node JS skills (I am sure you are fine). Can you provide more clarification for #2. I am not entirely sure what you are asking there. I'll be addressing 1-2 issues a week for the next couple months. So you'll see new versions coming out every week. Thanks!

Hey Tewen, Sry I missed the template attribute allowing user to customize JSON schema: new Field({ name: 'f1-66', role: 'Crackers', template: { subtype: 'CAPTURE' } }) I will have more test on other field location methods and come back to you! And here's a list of capabilities how users can set location/size of a field in OneSpan Sign: (1)directly set X/Y coordinates (2)use position extraction (guide: https://developer.esignlive.com/guides/feature-guides/position-extraction/) (3)use text anchor (guide: https://developer.esignlive.com/guides/feature-guides/text-anchors/) and two automatic extraction methods: (4)document extraction (guide: https://developer.esignlive.com/guides/feature-guides/document-extraction/) (5)text tags extraction (guide: https://developer.esignlive.com/guides/feature-guides/text-tags-extraction/) Duo

Thanks Duo - Those issues have been added as well. https://github.com/tewen/one-span-sign/issues It will be an iterative process as I learn more about those use cases. In the near term, I am going to fill out the remaining missing pieces of the API I have already worked with (this was initially based on a project I released a few years ago).